DT-1194: Speed up integration tests by running them in parallel #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrate UserBase to a field instead of using inheritance - replace sleep with Awaitility (sonar fix) - use log formatter (sonar fix) - use record for test settings - modify SnapshotIntegrationTest to use thread local storage for parallelization
# Conflicts: # src/test/java/bio/terra/app/controller/RepositoryApiControllerAccessTest.java # src/test/java/bio/terra/integration/AzureIntegrationTest.java # src/test/java/bio/terra/integration/FileTest.java # src/test/java/bio/terra/integration/IngestSnapshotIntegrationTest.java # src/test/java/bio/terra/integration/IngestTest.java # src/test/java/bio/terra/integration/IntegrationTestConfiguration.java # src/test/java/bio/terra/integration/SimpleScenarioFaultTests.java # src/test/java/bio/terra/integration/UsersBase.java # src/test/java/bio/terra/service/auth/iam/sam/SamRetryIntegrationTest.java # src/test/java/bio/terra/service/dataset/DatasetControlFilesIntegrationTest.java # src/test/java/bio/terra/service/dataset/DatasetIntegrationTest.java # src/test/java/bio/terra/service/dataset/DatasetSchemaUpdateIntegrationTest.java # src/test/java/bio/terra/service/dataset/DatasetSoftDeletesTest.java # src/test/java/bio/terra/service/dataset/SecureMonitoringIntegrationTest.java # src/test/java/bio/terra/service/dataset/SelfHostedDatasetIntegrationTest.java # src/test/java/bio/terra/service/filedata/DrsTest.java # src/test/java/bio/terra/service/job/JobPermissionTest.java # src/test/java/bio/terra/service/snapshot/SnapshotExportIntegrationTest.java # src/test/java/bio/terra/service/snapshot/SnapshotIntegrationTest.java # src/test/java/bio/terra/service/snapshot/SnapshotPermissionsIntegrationTest.java
pshapiro4broad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]
Addresses
Run integration tests even more in parallel to speed them up
Summary of changes
Use JUnit's concurrent execution mode, along with changing tests to be thread safe.
Note that unit and connected tests are currently broken on this branch due to configuration changes, once I have the integration tests working I'll go back and sort those out.
Testing Strategy