DT-1184: update db retry catch to use new exception class #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshapiro4broad
requested review from
rushtong and
rjohanek
and removed request for
a team
rjohanek
approved these changes
Jan 27, 2025
fboulnois
approved these changes
Jan 27, 2025
rushtong
approved these changes
Jan 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DT-1184
Addresses
If a SQL operation in a Step failed due to a conflict, it would no longer be retried, which was causing integration tests to fail, and could cause a user's flight to fail that would've otherwise succeeded.
Summary of changes
CannotSerializeTransactionException was deprecated in spring framework 6.0.3. At some point, this exception was no longer thrown by the spring SQL layer and code we have that depended on it stopped working.
There are a number of new possible exceptions to catch, but TransientDataAccessException seems like the most general type of exception which indicates a retryable SQL operation.
Testing Strategy