Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert "[DT-1122] Apply zizmor suggestions (#1879)" #1882

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-1122

Summary of changes

This partially reverts commit 8501e14. The merge chart version update step needs the GitHub token to be able to merge the new version.

@fboulnois fboulnois requested a review from a team as a code owner January 10, 2025 14:40
@fboulnois fboulnois requested review from pshapiro4broad and snf2ye and removed request for a team January 10, 2025 14:40
@fboulnois fboulnois force-pushed the fb-dt-1122-zizmor-partial-revert-v2 branch from f09fe6f to 559e592 Compare January 10, 2025 14:42
@fboulnois fboulnois changed the title Partially revert "[DT-1122] Apply zizmor suggestions (#1879)" Partially revert "[DT-1122] Apply zizmor suggestions (#1879)" Jan 10, 2025
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit 5f0c1b9 into develop Jan 10, 2025
14 checks passed
@fboulnois fboulnois deleted the fb-dt-1122-zizmor-partial-revert-v2 branch January 10, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants