[DT-1122] Apply zizmor suggestions
#1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
requested review from
rushtong and
s-rubenstein
and removed request for
a team
fboulnois
commented
Jan 8, 2025
| @@ -50,6 +50,7 @@ jobs: | |||
| with: | |||
| ref: ${{ inputs.ref }} | |||
| token: ${{ secrets.BROADBOT_TOKEN }} # this allows the push to succeed later | |||
| persist-credentials: false | |||
There was a problem hiding this comment.
I'm not sure about this one given the previous line
There was a problem hiding this comment.
I think we can always roll it back if necessary.
fboulnois
commented
Jan 8, 2025
Comment on lines
+88
to
+89
| env: | ||
| GCR_TAG: ${{ needs.bump_version.outputs.api_image_tag }} |
There was a problem hiding this comment.
This should work to replace the export call.
|
s-rubenstein
approved these changes
Jan 9, 2025
| @@ -50,6 +50,7 @@ jobs: | |||
| with: | |||
| ref: ${{ inputs.ref }} | |||
| token: ${{ secrets.BROADBOT_TOKEN }} # this allows the push to succeed later | |||
| persist-credentials: false | |||
There was a problem hiding this comment.
I think we can always roll it back if necessary.
rjohanek
approved these changes
Jan 9, 2025
fboulnois
added a commit
that referenced
this pull request
Jan 9, 2025
This partially reverts commit 8501e14.
fboulnois
added a commit
that referenced
this pull request
Jan 10, 2025
This partially reverts commit 8501e14.
fboulnois
added a commit
that referenced
this pull request
Jan 10, 2025
fboulnois
added a commit
that referenced
this pull request
Jan 10, 2025
This partially reverts commit 8501e14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1122
Summary
gradle/gradle-build-actiontov2.12.0, as previous versions have a vulnerability. Note that we cannot switch tov3due to https://broadworkbench.atlassian.net/browse/DT-1132Testing Strategy
In progress