[DT-1051] Remove flaky test #1872
Conversation
s-rubenstein
requested review from
fboulnois and
pshapiro4broad
and removed request for
a team
| azureBlobIOTestUtility.teardown(); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Instead of removing, what do you think about tagging it with @ignore instead? This test is still functional and could be used to test a particular error case, but is flaky so we don't want it to run with our nightly test runs.
There was a problem hiding this comment.
I agree, I would prefer to leave the test in until we remove the azure code it's testing.
Another solution is to add a @Category to this method so it's no longer run as part of Integration.class. TDR already has OnDemand for this purpose:
@Catregory(OnDemand.class)
fboulnois
left a comment
fboulnois
left a comment
There was a problem hiding this comment.
Based on internal discussion, lgtm 👍
| } | ||
|
|
||
| @Test | ||
| @Disabled |
There was a problem hiding this comment.
Make sure to verify that this works; this test is using JUnit 4 annotations and @Disabled is JUnit 5. I think the JUnit 4 tests are run using 5 internally so it should work. If it doesn't then using @Ignored will work.
There was a problem hiding this comment.
Oh yeah, I still see it in the test results - https://scans.gradle.com/s/a73cfymlzig3g/tests/overview
I don't see where we are using Disabled anywhere in TDR.
|
Jira ticket: https://broadworkbench.atlassian.net/browse/dt-1051
Addresses
Summary of changes
Testing Strategy