Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1050: Upgrade to current swagger-ui-dist library #1868

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

pshapiro4broad
Copy link
Member

@pshapiro4broad pshapiro4broad commented Dec 10, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/DT-1050

Addresses

Upgrade to latest swagger-ui-dist; fix code so that the client ID is populated in the swagger page.

Summary of changes

From page inspection, the selector for the client ID input is now client_id_authorizationCode. Verified this fix by running TDR locally.

Testing Strategy

Manually tested by opening the swagger UI page locally and using b2c auth to login. Verified that the fix was working by reverting the change and noting that the "client id" field was now empty.

…ient_id_authorizationCode`. Verified this fix by running TDR locally.
@pshapiro4broad pshapiro4broad requested a review from a team as a code owner December 10, 2024 20:45
@pshapiro4broad pshapiro4broad requested review from rushtong and fboulnois and removed request for a team December 10, 2024 20:45
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@pshapiro4broad pshapiro4broad merged commit 3ae35a9 into develop Dec 11, 2024
14 checks passed
@pshapiro4broad pshapiro4broad deleted the ps/dt-1050-swagger-ui-update-client-id branch December 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants