[DCJ-400] Upgrade com.diffplug.spotless 6.7.1 -> 6.25.0 #1771
Conversation
Ran `./gradlew spotlessApply` to pull in new changes.
okotsopoulos
added
dependency
Changes autogenerated by running: ./gradlew wrapper --gradle-version latest Rationale: two unit test runs failed due to heap space issues (see below), upgrading Gradle may include performance improvements. The Daemon will expire after the build after running out of JVM heap space. The project memory settings are likely not configured or are configured to an insufficient value. The daemon will restart for the next build, which may increase subsequent build times. These settings can be adjusted by setting 'org.gradle.jvmargs' in 'gradle.properties'. The currently configured max heap space is '512 MiB' and the configured max metaspace is '384 MiB'. For more information on how to set these values, please refer to https://docs.gradle.org/8.6/userguide/build_environment.html#sec:configuring_jvm_memory in the Gradle documentation. To disable this warning, set 'org.gradle.daemon.performance.disable-logging=true'. FAILURE: Build failed with an exception. * What went wrong: Gradle build daemon has been stopped: since the JVM garbage collector is thrashing
This reverts commit 838e6ac.
|
okotsopoulos
requested review from
rushtong and
fboulnois
and removed request for
a team
There was a problem hiding this comment.
Looks good, nice to see that spotless has added support for new-style switch.
After merging, could you add the commit for this change to .git-blame-ignore-revs? I don't think you can add it before merging up, since the squash merge will generate its own commit.
@pshapiro4broad good shout, will do! (At that time I will also add a comment to this effect in the build file so that future Dependabot PRs invite this engagement from reviewers.) |
Jira ticket: https://broadworkbench.atlassian.net/browse/DCJ-400
Addresses
The
com.diffplug.spotlessupgrade was initially included in a Dependabot grouped minor and patch upgrade PR: #1763We've since excluded it from grouped PRs, as new versions are likely to require developer intervention in the form of reformatting the code.
I'm electing to raise the upgrade separately since we already went to the trouble of investigating it in that earlier grouped PR.
Summary of changes
Minor dependency update to
com.diffplug.spotlessfrom 6.7.1 -> 6.25.0. https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.mdRan
./gradlew spotlessApplyto pull in new changes.Testing Strategy
CI build and tests should succeed.