Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-400-gradle]: Bump org.liquibase.gradle from 2.2.1 to 3.0.0 #1765

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 6, 2024

Bumps org.liquibase.gradle from 2.2.1 to 3.0.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps org.liquibase.gradle from 2.2.1 to 3.0.0.

---
updated-dependencies:
- dependency-name: org.liquibase.gradle
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 6, 2024

The following labels could not be found: dependency, gradle.

@dependabot dependabot bot requested review from a team as code owners August 6, 2024 17:40
@dependabot dependabot bot requested review from rushtong and okotsopoulos and removed request for a team August 6, 2024 17:40
@okotsopoulos okotsopoulos marked this pull request as draft August 6, 2024 19:39
@snf2ye
Copy link
Contributor

snf2ye commented Aug 7, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 7, 2024

Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Copy link

sonarqubecloud bot commented Aug 7, 2024

@okotsopoulos okotsopoulos added dependency Pull requests that update a dependency file gradle Pull request that updates a Gradle file labels Aug 7, 2024
Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thank you, @snf2ye !

Comment on lines 23 to +25
classpath('io.swagger.codegen.v3:swagger-codegen:3.0.52')
// Required for gradle liquibase plugin
classpath ('org.liquibase:liquibase-core:4.26.0')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers:

  • Adding this classpath to the buildscript is new requirement with gradle liquibase 3.0.0
  • Ideally, we wouldn't pin the version of liquibase-core. However, the version appears to be required when defining the classpath. Additionally, we need to pin the version for the implementation of liquibase-core, or it would default to 4.24.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout -- I will revisit this as part of our latest bulk version update to see if it's still needed.

When we upgrade Spring Boot to latest -- 3.3.2 -- we'll get liquibase versioned at 4.27.0, do you think that might allow us to remove the version here? https://github.com/spring-projects/spring-boot/blob/v3.3.2/spring-boot-project/spring-boot-dependencies/build.gradle#L1066

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, it wouldn't build without a version here. But, maybe I was just missing something.

@snf2ye snf2ye marked this pull request as ready for review August 7, 2024 17:42
@snf2ye
Copy link
Contributor

snf2ye commented Aug 7, 2024

I also confirmed that at least the ./gradlew dropall command still works!

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@snf2ye snf2ye merged commit 7611a01 into develop Aug 7, 2024
13 checks passed
@snf2ye snf2ye deleted the dependabot/gradle/develop/org.liquibase.gradle-3.0.0 branch August 7, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Pull requests that update a dependency file gradle Pull request that updates a Gradle file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants