[DR-3476] Include additional fields in DRS getAccessURL Bard logs #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the snapshot name and billing profile id to the DRS log for getAccessURL. This will allow us to know which snapshots and billing profiles (sometimes associated with a specific project) users are requesting data from.
Ghost-in-a-Jar
approved these changes
Aug 1, 2024
snf2ye
approved these changes
Aug 1, 2024
samanehsan
requested review from
rushtong and
fboulnois
and removed request for
a team
okotsopoulos
approved these changes
Aug 5, 2024
src/main/java/bio/terra/app/usermetrics/UserLoggingMetrics.java
Outdated
Show resolved
Hide resolved
samanehsan
force-pushed
the
se/DR-3476-update-drs-bard-log-info
branch
from
0ff6555 to
ea99ff5
Compare
samanehsan
force-pushed
the
se/DR-3476-update-drs-bard-log-info
branch
from
ea99ff5 to
69adc4c
Compare
|
|
Thanks for the review @okotsopoulos! I made the changes you requested and added a note about how I tested the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DR-3476
Addresses
Key stakeholders such as the NIH want to know the usage patterns of the data that they are storing. Adding the snapshot name is more informative than using just the snapshot ids. This along with the addition of the billing profile id, dataset id and dataset name allows us to answer questions like, "What are the top X datasets and/or snapshots (of billing profile Y) that users are requesting data from?"
Summary of changes
Add the following fields to the DRS Bard log for getAccessURL (Note these are already available in the snapshot object that gets retrieved from the database, but these fields were not included in the cached snapshot object):
Testing Strategy
Local testing:
usermetrics.bardBasePath=https://terra-bard-dev.appspot.cominapplication.propertiesdrsHackytest to hit the breakpoint