[DC-1170] Add code for get and delete requests #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
rushtong and
aarohinadkarni
and removed request for
a team
pshapiro4broad
approved these changes
Jul 25, 2024
|
|
||
| @Override | ||
| public StepResult undoStep(FlightContext context) throws InterruptedException { | ||
| // can't undo delete |
There was a problem hiding this comment.
Is there a need to log here? I don't think anyone will look at this log message, and if they did, I don't know what they'd do with this information.
There was a problem hiding this comment.
I don't think we need to, but I was following the example here: https://github.com/DataBiosphere/jade-data-repo/blob/develop/src/main/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotAuthzResource.java#L39
I think that might be useful information in the case that things end up in a bad state? What are your thoughts?
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
...io/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStepTest.java
Outdated
Show resolved
Hide resolved
...io/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStepTest.java
Outdated
Show resolved
Hide resolved
snf2ye
reviewed
Jul 26, 2024
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshotbuilder/SnapshotRequestDao.java
Outdated
Show resolved
Hide resolved
snf2ye
reviewed
Jul 26, 2024
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
snf2ye
reviewed
Jul 26, 2024
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
...va/bio/terra/service/snapshot/flight/delete/DeleteOutstandingSnapshotAccessRequestsStep.java
Outdated
Show resolved
Hide resolved
snf2ye
approved these changes
Jul 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/dc-1170
Addresses
Summary of changes
Testing Strategy