[DR-3356] Ensure that ingests always exclusively lock the dataset when bulk mode is set to true #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is set to true This feels safe to do since the only real reason someone would use bulk is to speed up file ingests. This may lead to datasets being exclusively locked more than they should (in the case where there are no files) but that feels like a reasonable tradeoff
nmalfroy
requested review from
snf2ye,
samanehsan and
okotsopoulos
as code owners
|
Kudos, SonarCloud Quality Gate passed! |
samanehsan
approved these changes
Nov 13, 2023
okotsopoulos
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Thanks for fixing! I double checked our Swagger definition and no changes to documentation are required there (it presently indicates that a combined ingest with bulk mode enabled will exclusively lock the dataset, so this brings the behavior in line with that expectation).
| @@ -142,7 +142,12 @@ public DatasetIngestFlight(FlightMap inputParameters, Object applicationContext) | |||
| .forEach(s -> this.addStep(s.step(), s.retryRule())); | |||
| } | |||
|
|
|||
| addStep(new LockDatasetStep(datasetService, datasetId, true), lockDatasetRetry); | |||
| // Originally we didn't exclusively lock the dataset, the thinking being that there might | |||
There was a problem hiding this comment.
Thanks for adding the reasoning here!
There was a problem hiding this comment.
Of course! I want to be nicer to future us :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels safe to do since the only real reason someone would use bulk is to speed up file ingests. This may lead to datasets being exclusively locked more than they should (in the case where there are no files) but that feels like a reasonable tradeoff