DT-1219: Allow un-selecting auth domains on snapshot create #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
sh/DT-1219
|
| Run status |
|
| Run duration | 02m 52s |
| Commit |
|
| Committer | Shelby Holden |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
s-rubenstein
reviewed
Feb 7, 2025
| @@ -191,9 +191,10 @@ function FullViewSnapshotButton({ | |||
| sx={{ height: '2.5rem' }} | |||
| disabled={userGroups ? userGroups.length <= 1 : true} | |||
| options={userGroups ? userGroups.map((group) => group.groupName) : []} | |||
| name="authorization-domain" | |||
| name="Select Authorization Domain" | |||
There was a problem hiding this comment.
Changing the name here will affect tests, since that generates the IDs by which we grab the component.
There was a problem hiding this comment.
Ah, thanks!
I'm now formatting the id with lodash's "kebab case", so hopefully that will at least generate a more meaningful id.
|
snf2ye
changed the title
s-rubenstein
approved these changes
Feb 7, 2025
snf2ye
requested review from
rushtong and
fboulnois
and removed request for
a team
fboulnois
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/DT-1219
Before:
https://drive.google.com/file/d/1SLNW12OJjLjTDkf8dQMae2NUKb_qVbc-/view?usp=drive_link
After:
https://drive.google.com/file/d/1yzDz2hJyQWYRWGvi7jVZ2nsC1JZ67iVx/view?usp=drive_link
Included Changes