DT-454: Add GAR specific build action #1747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
gr-DT-454-artifact-registry
|
| Run status |
|
| Run duration | 03m 06s |
| Commit |
|
| Committer | Gregory Rushton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
|
rushtong
requested review from
s-rubenstein and
fboulnois
and removed request for
a team
fboulnois
approved these changes
Jan 31, 2025
| - name: Set up Cloud SDK | ||
| uses: google-github-actions/setup-gcloud@v2 | ||
| - name: Explicitly auth Docker for Artifact Registry | ||
| run: gcloud auth configure-docker $GOOGLE_DOCKER_REPOSITORY --quiet |
There was a problem hiding this comment.
Suggested change
| run: gcloud auth configure-docker $GOOGLE_DOCKER_REPOSITORY --quiet | |
| run: gcloud auth configure-docker "$GOOGLE_DOCKER_REPOSITORY" --quiet |
| BUMP_TAG: ${{ steps.tag.outputs.tag }} | ||
| - name: Build image | ||
| run: | | ||
| docker build -t $TAGGED . |
There was a problem hiding this comment.
Suggested change
| docker build -t $TAGGED . | |
| docker build -t "$TAGGED" . |
| # Publish images | ||
| - name: Push image | ||
| run: | | ||
| docker push $TAGGED |
There was a problem hiding this comment.
Suggested change
| docker push $TAGGED | |
| docker push "$TAGGED" |
|
Closing this PR. We've applied the Google Migration tool to all affected repos so this action isn't necessary now. Additionally, this approach will not work with the current umbrella deployment process in place, we would need to update all paths in all repos at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-454
Summary
We take inspiration from the existing build job and from an existing Terra build process. We have an existing Trivy action, so that is not included in this PR. We pull in the Terra bumper action which provides semantic versioning. This will supercede/replace the existing TDR
helm_tag_bumpfunctionality.Images can be accessed via a suitable
firecloud.orgaccount:Future work
When this is complete and pushing images to GAR, we will need to: