Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-1151] Migrate away from @mui/styles - part 3 - src/components #1746

Merged
merged 11 commits into from
Jan 30, 2025

Conversation

rjohanek
Copy link
Contributor

@rjohanek rjohanek commented Jan 27, 2025

Summary:
Followed the template of this PR: #1730

Changes:
Deleted TablePicker because it was unused
Updated EditableFieldView, ManageUsersView, Logo, Toast, IdleStatusMonitor, ServerErrorView, and WelcomeView

EditableFieldView: EditableFieldView
ManageUsersView: https://github.com/user-attachments/assets/6f76856d-31ef-4404-9624-7c2f9c26b143
Logo: logo
Toast: Toast
IdleStatusMonitor:
IdleStatusMonitor
ServerErrorView (this is broken on dev as well, so I filed a ticket):
ServerErrorView1
ServerErrorView2
WelcomeView:
welcomeView

@rjohanek rjohanek requested a review from a team as a code owner January 27, 2025 20:59
@rjohanek rjohanek requested review from pshapiro4broad and s-rubenstein and removed request for a team January 27, 2025 20:59
Copy link

cypress bot commented Jan 27, 2025

jade-data-repo-ui    Run #4002

Run Properties:  status check passed Passed #4002  •  git commit c26a8d1601 ℹ️: Merge f3f20730a73dd9961b7f1d2e8e70d1dae34c0d5f into 862acaaa9bafce91034ccb8ffc97...
Project jade-data-repo-ui
Branch Review rj/dt-1151-remove-mui-styles-part3
Run status status check passed Passed #4002
Run duration 02m 52s
Commit git commit c26a8d1601 ℹ️: Merge f3f20730a73dd9961b7f1d2e8e70d1dae34c0d5f into 862acaaa9bafce91034ccb8ffc97...
Committer Rachel Johanek
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 17
View all changes introduced in this branch ↗︎

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, I like that the refactoring split things into smaller components 👍

@rjohanek rjohanek merged commit 539825d into develop Jan 30, 2025
9 checks passed
@rjohanek rjohanek deleted the rj/dt-1151-remove-mui-styles-part3 branch January 30, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants