[DT-1137]After creating a snapshot - dataset tab appears selected even after selecting the snapshot tab #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjohanek
requested review from
snf2ye and
fboulnois
and removed request for
a team
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
rj/dt-1137-update-tab
|
| Run status |
|
| Run duration | 03m 12s |
| Commit |
|
| Committer | Rachel Johanek |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
snf2ye
approved these changes
Jan 22, 2025
pshapiro4broad
approved these changes
Jan 22, 2025
src/components/common/TabWrapper.tsx
Outdated
| const locationSplit = history.location.pathname.split('/'); | ||
| const selectedTab = `/${locationSplit[1] || 'datasets'}`; | ||
| useEffect(() => { | ||
| const locationSplit = history.location.pathname.split('/'); |
There was a problem hiding this comment.
Could this use location instead? Is there a difference between history.location vs location? If so, that would make it clearer why the useEffect() is needed here.
Suggested change
| const locationSplit = history.location.pathname.split('/'); | |
| const locationSplit = location.pathname.split('/'); |
fboulnois
approved these changes
Jan 22, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When changing tabs is routed through the SnapshotPopup the window goes to the correct location, but the incorrect tab is selected. This allows the selected tab to be updated whenever the window is changed.
Changes:
add useEffect for selected tab dependent on current window location
Testing:
Just visually tested as in the video.
Before:
https://github.com/user-attachments/assets/c7d4dd5d-c0be-4d80-b803-cc5cfa2fe645
After:
https://github.com/user-attachments/assets/844fe0ae-4ca1-490c-a327-d53f27ad9122