[DT-1001] select billing profile #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
rushtong and
rjohanek
and removed request for
a team
s-rubenstein
changed the title
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
sr/dt-1001-select-billing-profile
|
| Run status |
|
| Run duration | 02m 51s |
| Commit |
|
| Committer | Sky Rubenstein |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
rjohanek
reviewed
Jan 13, 2025
rjohanek
reviewed
Jan 13, 2025
|
@rjohanek oh I see that now - we should work on updating ticket names when we make those sorts of changes as well. |
rushtong
approved these changes
Jan 13, 2025
Screen.Recording.2025-01-13.at.4.38.15.PM.mov |
rjohanek
reviewed
Jan 14, 2025
rjohanek
reviewed
Jan 14, 2025
| id="snapshot-name" | ||
| label="Snapshot Name" | ||
| value={snapshotName} | ||
| onChange={(e) => setSnapshotName(e.target.value)} |
There was a problem hiding this comment.
do we need to do input validation here for name and description because we are sending it to the backend?
There was a problem hiding this comment.
The backend has validation - I checked other places and TDR UI doesn't currently validate inputs - it just pushes the problem to the API. We probably want clientside validation at some point, but that should be out of scope of this. (That's also when I would add more testing)
|
LGTM! Thx |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-01-10.at.2.00.02.PM.mov