Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-1122] Apply zizmor suggestions #1733

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-1122

Summary

  • Do not persist credentials if not needed
  • Use shell variable expansion instead of template expansion

@fboulnois fboulnois requested a review from a team as a code owner January 8, 2025 20:44
@fboulnois fboulnois requested review from pshapiro4broad and snf2ye and removed request for a team January 8, 2025 20:44
Copy link

cypress bot commented Jan 9, 2025

jade-data-repo-ui    Run #3971

Run Properties:  status check passed Passed #3971  •  git commit c5b4ce2752 ℹ️: Merge 21dc73bb76f03da2498bb7a0fbaed392dd4194e9 into 6b8602e5cdee7ba3942716faefca...
Project jade-data-repo-ui
Branch Review fb-dt-1122-apply-zizmor-fixes
Run status status check passed Passed #3971
Run duration 03m 08s
Commit git commit c5b4ce2752 ℹ️: Merge 21dc73bb76f03da2498bb7a0fbaed392dd4194e9 into 6b8602e5cdee7ba3942716faefca...
Committer fboulnois
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 17
View all changes introduced in this branch ↗︎

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois force-pushed the fb-dt-1122-apply-zizmor-fixes branch from 5ed5163 to 21dc73b Compare January 15, 2025 15:05
@fboulnois fboulnois merged commit 7cbc06e into develop Jan 15, 2025
9 checks passed
@fboulnois fboulnois deleted the fb-dt-1122-apply-zizmor-fixes branch January 15, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants