DT-1125: Migrate away from @mui/styles Part 2 - ThemeProvider to use @mui/system #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ThemeProvider Reference
snf2ye
force-pushed
the
sh/dt-1110-test-update-away-from-mui-styles
branch
from
ba7ea8c to
477b913
Compare
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
sh/dt-1110-test-update-away-from-mui-styles
|
| Run status |
|
| Run duration | 02m 45s |
| Commit |
|
| Committer | Shelby Holden |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
This is what is referenced in docs: https://mui.com/material-ui/customization/theming/
|
fboulnois
approved these changes
Jan 7, 2025
snf2ye
requested review from
rushtong and
s-rubenstein
and removed request for
a team
snf2ye
changed the title
s-rubenstein
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
More details about this migration here: #1730
Breaking out this change to help simplify other PRs.
Included Changes
Switch references from
@mui/stylesto@mui/material/stylesFrom migration guide: https://mui.com/material-ui/migration/v5-style-changes/#update-themeprovider-import
Note
I don't totally understand why this appears to still be working in combination with the sx components. We may need to eventually migrate away from this as well. But, I think that this ThemeProvider is providing the theme even in the changes in this PR to use the sx prop because things break if the theme is not referenced correctly.
But, I want to go ahead and remove all references directly to @mui/styles.