DR-3313: Point to POST Query Data Endpoints #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snf2ye
requested review from
nmalfroy,
samanehsan and
okotsopoulos
as code owners
snf2ye
force-pushed
the
sh-dr-3313-large-filter
branch
from
c1465f4 to
35e9914
Compare
nmalfroy
approved these changes
Nov 13, 2023
| @@ -787,16 +787,19 @@ export function* watchGetDatasetByIdSuccess(): any { | |||
|
|
|||
| export function* previewData({ payload }: any): any { | |||
There was a problem hiding this comment.
While you're in here, should we rename the method viewData? Or something that doesn't have preview in the name?
There was a problem hiding this comment.
I think it would be hard to actually remove all of the references to "preview" data. I think I'd rather leave it all as preview rather than changing only some of the references to the new name, especially since this would only be a code-facing change rather than user-facing.
Passing run #3119 ↗︎
Details:
Review all test suite changes for PR #1540 ↗︎ |
|||||||||||||||
samanehsan
reviewed
Nov 14, 2023
samanehsan
reviewed
Nov 14, 2023
snf2ye
force-pushed
the
sh-dr-3313-large-filter
branch
from
09559aa to
8bb6bab
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
I've deployed the latest to my personal namespace and confirmed that it works for large filter queries. |
samanehsan
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge-Order requirement
Included Changes
We should not notice any changes in the UI except that the UI can handle larger filter requests when creating a snapshot.
Testing
While the UI still struggles a little bit, I was able to filter on 1000 items and create a snapshot.
Screen.Recording.2023-11-13.at.1.17.22.PM.mov