DT-1144: Update Support Destination URLs #2768
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtong
commented
Jan 24, 2025
Comment on lines
-77
to
-81
| export const getFileNameFromHttpResponse = (response) => { | ||
| const respHeaders = response.headers; | ||
| return respHeaders.get('Content-Disposition').split(';')[1].trim().split('=')[1]; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Drive-by fix: unused method.
rushtong
commented
Jan 24, 2025
Comment on lines
-45
to
-48
| export const sleep = (ms) => { | ||
| return new Promise(resolve => setTimeout(resolve, ms)); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Drive-by fix: unused method.
rushtong
commented
Jan 24, 2025
Comment on lines
-20
to
-21
| getGoogleClientId: async () => (await getConfig()).clientId, | ||
|
|
There was a problem hiding this comment.
Drive-by fix: unused method.
rushtong
requested review from
snf2ye and
fboulnois
and removed request for
a team
rjohanek
reviewed
Jan 29, 2025
| subject: subject, | ||
| // BEWARE changing the following ids or values! If you change them then you must thoroughly test. |
There was a problem hiding this comment.
what was the purpose of these fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1144
Summary
RequestFormandSupportRequestModal) that make use of support request functionality.SupportRequestsPagecomponent to the file name,RequestForm, for consistencyTesting
To test locally, this needs to be run against a local running consent with the following config setting:
Visit the Contact Us form on any page, and the Request a New Role from the user profile page. These are the two places where we invoke the new support urls.
Have you read Terra's Contributing Guide lately? If not, do that first.