-
Notifications
You must be signed in to change notification settings - Fork 5
chore: updated dev dependencies (#4309) #4318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b5db749
73b6d2d
e2b743f
8345ce8
7946d4d
ca118f9
f6ad40e
ff993b9
556f8ef
4c3e663
c882663
8dcb2c8
e7e9834
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
#!/usr/bin/env sh | ||
. "$(dirname -- "$0")/_/husky.sh" | ||
|
||
echo "Checking commit message" | ||
|
||
# Check for issue number | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
echo '🏗️👷 Checking your project before committing' | ||
|
||
# Check Prettier | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
{} | ||
{ | ||
"trailingComma": "es5" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,10 @@ import { | |
} from "@databiosphere/findable-ui/lib/components/Export/common/entities"; | ||
import { CurrentQuery } from "@databiosphere/findable-ui/lib/components/Export/components/ExportSummary/components/ExportCurrentQuery/exportCurrentQuery"; | ||
import { Summary } from "@databiosphere/findable-ui/lib/components/Export/components/ExportSummary/components/ExportSelectedDataSummary/exportSelectedDataSummary"; | ||
import { ANCHOR_TARGET } from "@databiosphere/findable-ui/lib/components/Links/common/entities"; | ||
import { | ||
ANCHOR_TARGET, | ||
REL_ATTRIBUTE, | ||
} from "@databiosphere/findable-ui/lib/components/Links/common/entities"; | ||
import { getConfig } from "@databiosphere/findable-ui/lib/config/config"; | ||
import { ViewContext } from "@databiosphere/findable-ui/lib/config/entities"; | ||
import { | ||
|
@@ -712,11 +715,14 @@ export const buildCookieBanner = (): React.ComponentProps< | |
"This website uses cookies for security and analytics purposes. By using this site, you agree to these uses.", | ||
secondaryAction: C.ButtonOutline({ | ||
children: "Learn More", | ||
/* eslint-disable sonarjs/link-with-target-blank -- const used for NOOPRNER NOREFERRER */ | ||
onClick: () => | ||
window.open( | ||
"https://data.humancellatlas.org/privacy", | ||
ANCHOR_TARGET.BLANK | ||
ANCHOR_TARGET.BLANK, | ||
REL_ATTRIBUTE.NO_OPENER_NO_REFERRER | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed this link to add |
||
), | ||
/* eslint-enable sonarjs/link-with-target-blank -- check target blank links for the rest of the file */ | ||
}), | ||
}; | ||
}; | ||
|
@@ -1642,7 +1648,9 @@ function getAnalysisPortalKeyValueFn( | |
const [, value] = keyValue; | ||
if (value && typeof value === "string") { | ||
const url = analysisPortals.find(({ label }) => label === value)?.url; | ||
url && window.open(url, ANCHOR_TARGET.BLANK); | ||
if (url) { | ||
window.open(url, ANCHOR_TARGET.BLANK); | ||
} | ||
frano-m marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
}; | ||
} | ||
|
@@ -1957,7 +1965,7 @@ export function getGeneratedMatricesActionsColumnDef<T>(): ColumnDef<T> { | |
* @returns anatomical entity column def. | ||
*/ | ||
export function getGeneratedMatricesAnatomicalEntityColumnDef< | ||
T | ||
T, | ||
>(): ColumnDef<T> { | ||
return { | ||
accessorKey: HCA_DCP_CATEGORY_KEY.ORGAN, | ||
|
@@ -1978,7 +1986,7 @@ export function getGeneratedMatricesAnatomicalEntityColumnDef< | |
* @returns content description column def. | ||
*/ | ||
export function getGeneratedMatricesContentDescriptionColumnDef< | ||
T | ||
T, | ||
>(): ColumnDef<T> { | ||
return { | ||
accessorKey: HCA_DCP_CATEGORY_KEY.CONTENT_DESCRIPTION, | ||
|
@@ -2051,7 +2059,7 @@ export function getGeneratedMatricesGenusSpeciesColumnDef<T>(): ColumnDef<T> { | |
* @returns library construction method column def. | ||
*/ | ||
export function getGeneratedMatricesLibraryConstructionMethodColumnDef< | ||
T | ||
T, | ||
>(): ColumnDef<T> { | ||
return { | ||
accessorKey: HCA_DCP_CATEGORY_KEY.LIBRARY_CONSTRUCTION_METHOD, | ||
|
@@ -2072,7 +2080,7 @@ export function getGeneratedMatricesLibraryConstructionMethodColumnDef< | |
* @returns matrix cell count column def. | ||
*/ | ||
export function getGeneratedMatricesMatrixCellCountColumnDef< | ||
T | ||
T, | ||
>(): ColumnDef<T> { | ||
return { | ||
accessorKey: HCA_DCP_CATEGORY_KEY.MATRIX_CELL_COUNT, | ||
|
@@ -2416,12 +2424,15 @@ export const renderWhenUnAuthenticated = ( | |
* @returns total cells from cellSuspensions. | ||
*/ | ||
function rollUpTotalCells(entityResponse: EntityResponse): number | null { | ||
return entityResponse.cellSuspensions.reduce((acc, { totalCells }) => { | ||
if (totalCells) { | ||
acc = (acc ?? 0) + totalCells; | ||
} | ||
return acc; | ||
}, null as null | number); | ||
return entityResponse.cellSuspensions.reduce( | ||
(acc, { totalCells }) => { | ||
if (totalCells) { | ||
acc = (acc ?? 0) + totalCells; | ||
} | ||
return acc; | ||
}, | ||
null as null | number | ||
); | ||
} | ||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frano-m this is triggered for cases like the below in app/apis/catalog/ncpi-catalog/common/entities.ts. Not sure if it should be disabled, kept as a warn, and/or if we should remove those cases, do you have thoughts?