feat: 4305 added gspread analytics package #4314
Conversation
There was a problem hiding this comment.
I haven't looked at this fully yet, but one thing that comes to mind is that the version in setup.py should be updated -- specifically I intended it to be semantic versioning, so I would increase the version to 3.1.0, since I think this a non-breaking feature change
mrtopsyt
force-pushed
the
jonah/4305-gspread-analytics-package
branch
from
f7a8e93 to
04d03af
Compare
|
@hunterckx whoops, thanks for letting me know, I wasn't familiar with setupTools. I bumped the version and added the new dependencies in |
| # Build Drive API | ||
| drive_credentials = extract_credentials(authentication_response) | ||
| gc = gspread.authorize(drive_credentials) | ||
| drive_api = build('drive', 'v3', credentials=drive_credentials) |
There was a problem hiding this comment.
I imagine that, since authenticate_gspread and authenticate_drive_api exist, they should be used here instead of initializing the API clients directly
|
|
||
| def authenticate_drive_api(authentication_response): | ||
| """Authenticates the Drive API using the credentials in the tuple from api.authenticate""" | ||
| return build('drive', 'v3', credentials=extract_credentials(authentication_response)) |
There was a problem hiding this comment.
The tuple returned from calling api.authenticate with drive_service_params should have the Drive API as its first item, so I don't think calling build here is necessary
|
Thanks for those reviews @hunterckx! Let me know if it looks good now |
MillenniumFalconMechanic
deleted the
jonah/4305-gspread-analytics-package
branch
3 participants
Ticket
Closes #4305.
Reviewers
@hunterckx .
@NoopDog
Changes
Known Issues