feat: use n-tags in project detail page side column (#3759) #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
reviewed
Nov 23, 2023
| ); // Nucleic Acid Source | ||
| details.set(DATA_SUMMARY.PAIRED_END, stringifyValues(pairedEnd)); // Paired End | ||
| details.set( |
There was a problem hiding this comment.
Because Paired End is only a set of three possible values, let's revert and just stringify the values.
frano-m
reviewed
Nov 23, 2023
| ORGANISM_TYPE, | ||
| PAIRED_END, |
There was a problem hiding this comment.
Given Paired End is a set of three possible values, revert here and elsewhere all Paired End related changes. Will will always show the values, stringyified...
hunterckx
force-pushed
the
hunter/3759-hca-project-detail-ntags
branch
from
9e6696b to
5f92940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLURALIZED_METADATA_LABELI wasn't sure what use for paired end, since its values are booleans, so I just used "values"Paired end is unchanged, as discussed below