Skip to content

Backport: 918fbf5 (PR #6971), dd3b28e (#6976, PR #6977) #6974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 27, 2025

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Mar 15, 2025

Checklist

Author

  • Target branch is develop
  • Name of PR branch matches backports/<7-digit SHA1 of most recent backported commit>
  • PR title contains the 7-digit SHA1 of the backported commits
  • PR title references the issues relating to the backported commits
  • PR title references the PRs that introduced the backported commits

Author (before every review)

  • Merged develop into PR branch to integrate upstream changes
  • Ran make requirements_update or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not modify requirements*.txt
  • This PR is labeled reqs or does not modify requirements*.txt

System administrator (after approval)

  • Actually approved the PR
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Added sandbox label or PR is labeled no sandbox
  • Pushed PR branch to GitLab dev or PR is labeled no sandbox
  • Pushed PR branch to GitLab anvildev or PR is labeled no sandbox
  • Build passes in sandbox deployment or PR is labeled no sandbox
  • Build passes in anvilbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in sandbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in anvilbox deployment or PR is labeled no sandbox
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference (to this PR) to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab dev
  • Pushed merge commit to GitLab anvildev
  • Build passes on GitLab dev
  • Reviewed build logs for anomalies on GitLab dev
  • Build passes on GitLab anvildev
  • Reviewed build logs for anomalies on GitLab anvildev
  • Deleted PR branch from GitHub
  • Deleted PR branch from GitLab dev
  • Deleted PR branch from GitLab anvildev

Operator

  • PR is assigned to no one

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Mar 15, 2025
@coveralls
Copy link

coveralls commented Mar 15, 2025

Coverage Status

coverage: 85.683%. remained the same
when pulling be87de3 on backports/918fbf5
into f7c3bee on develop.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (f7c3bee) to head (be87de3).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6974   +/-   ##
========================================
  Coverage    85.63%   85.63%           
========================================
  Files          151      151           
  Lines        21658    21658           
========================================
  Hits         18546    18546           
  Misses        3112     3112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the changes from #6977. You don't need to change the branch name.

@dsotirho-ucsc
Copy link
Contributor Author

This backport PR now contains 918fbf5 (anvilprod snapshot removed due to AccessDenied) and dd3b28e (anvilprod snapshot removed due to || joiner)

Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See CL.

@hannes-ucsc hannes-ucsc added 0 reviews [process] Lead didn't request any changes 1 review [process] Lead requested changes once and removed 0 reviews [process] Lead didn't request any changes labels Mar 19, 2025
@hannes-ucsc hannes-ucsc removed their assignment Mar 19, 2025
@dsotirho-ucsc dsotirho-ucsc self-assigned this Mar 26, 2025
@dsotirho-ucsc dsotirho-ucsc changed the title Backport: 918fbf5 (PR #6971) Backport: 918fbf5 (PR #6971), dd3b28e (#6976, PR #6977), 2a9ee235 (#6997, PR #6999) Mar 27, 2025
@dsotirho-ucsc dsotirho-ucsc changed the title Backport: 918fbf5 (PR #6971), dd3b28e (#6976, PR #6977), 2a9ee235 (#6997, PR #6999) Backport: 918fbf5 (PR #6971), dd3b28e (#6976, PR #6977) Mar 27, 2025
@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Mar 27, 2025
@hannes-ucsc hannes-ucsc merged commit 71a10b0 into develop Mar 27, 2025
9 checks passed
@dsotirho-ucsc dsotirho-ucsc deleted the backports/918fbf5 branch March 27, 2025 21:37
@dsotirho-ucsc dsotirho-ucsc removed their assignment Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 review [process] Lead requested changes once no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants