-
Notifications
You must be signed in to change notification settings - Fork 2
Backport: 918fbf5 (PR #6971), dd3b28e (#6976, PR #6977) #6974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ails due to joiner (#6976)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6974 +/- ##
========================================
Coverage 85.63% 85.63%
========================================
Files 151 151
Lines 21658 21658
========================================
Hits 18546 18546
Misses 3112 3112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the changes from #6977. You don't need to change the branch name.
f67c8bf
to
6554568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See CL.
6554568
to
be87de3
Compare
Checklist
Author
develop
Name of PR branch matchesbackports/<7-digit SHA1 of most recent backported commit>
Author (before every review)
develop
into PR branch to integrate upstream changesmake requirements_update
or this PR does not modifyrequirements*.txt
,common.mk
,Makefile
andDockerfile
R
tag to commit title or this PR does not modifyrequirements*.txt
reqs
or does not modifyrequirements*.txt
System administrator (after approval)
no sandbox
Operator (before pushing merge the commit)
sandbox
label or PR is labeledno sandbox
dev
or PR is labeledno sandbox
anvildev
or PR is labeledno sandbox
sandbox
deployment or PR is labeledno sandbox
anvilbox
deployment or PR is labeledno sandbox
sandbox
deployment or PR is labeledno sandbox
anvilbox
deployment or PR is labeledno sandbox
p
tagsOperator (after pushing the merge commit)
dev
anvildev
dev
dev
anvildev
anvildev
dev
anvildev
Operator
Shorthand for review comments
L
line is too longW
line wrapping is wrongQ
bad quotesF
other formatting problem