Implement mirror_source (#6860) #6905

nadove-ucsc · 2025-02-12T23:23:27Z

Connected issues: #6860

Checklist

Author

PR is a draft
Target branch is develop
Name of PR branch matches issues/<GitHub handle of author>/<issue#>-<slug>
On ZenHub, PR is connected to all issues it (partially) resolves
PR description links to connected issues
PR title matches¹ that of a connected issue _{or comment in PR explains why they're different}
PR title references all connected issues
For each connected issue, there is at least one commit whose title references that issue

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all connected issues}
This PR partially resolves each of the connected issues _{or does not have the partial label}

Author (chains)

This PR is blocked by previous PR in the chain _{or is not chained to another PR}
The blocking PR is labeled base _{or this PR is not chained to another PR}
This PR is labeled chained _{or is not chained to another PR}

Author (reindex, API changes)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}
This PR and its connected issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any connected issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues connected to this PR}

Author (before every review)

Rebased PR branch on develop, squashed old fixups
Ran make requirements_update _{or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}

Peer reviewer (after approval)

PR is not a draft
Ticket is in Review requested column
PR is awaiting requested review from system administrator
PR is assigned to only the system administrator

System administrator (after approval)

Actually approved the PR
Labeled connected issues as demo or no demo
Commented on connected issues about demo expectations _{or all connected issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Moved connected issues to Approved column
PR is assigned to only the operator

Operator (before pushing merge the commit)

System administrator

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (before pushing merge the commit)

Operator (chain shortening)

Changed the target branch of the blocked PR to develop _{or this PR is not labeled base}
Removed the chained label from the blocked PR _{or this PR is not labeled base}
Removed the blocking relationship from the blocked PR _{or this PR is not labeled base}
Removed the base label from this PR _{or this PR is not labeled base}

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

codecov · 2025-02-15T08:16:02Z

Codecov Report

Attention: Patch coverage is 85.53719% with 35 lines in your changes missing coverage. Please review.

Project coverage is 85.68%. Comparing base (9ed43c5) to head (60375a3).

Files with missing lines	Patch %	Lines
test/integration_test.py	0.00%	14 Missing ⚠️
src/azul/queues.py	78.37%	8 Missing ⚠️
src/azul/indexer/mirror_controller.py	74.07%	7 Missing ⚠️
src/azul/azulclient.py	88.46%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6905      +/-   ##
===========================================
- Coverage    85.68%   85.68%   -0.01%     
===========================================
  Files          148      151       +3     
  Lines        21567    21687     +120     
===========================================
+ Hits         18480    18582     +102     
- Misses        3087     3105      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/azul/azulclient.py

src/azul/indexer/mirror_controller.py

dsotirho-ucsc

Looks great. Just a couple questions.

dsotirho-ucsc · 2025-03-11T16:33:33Z

scripts/mirror.py

@@ -0,0 +1,61 @@
+"""
+Copy all files from the public sources in a catalog the current deployment's


Suggested change

Copy all files from the public sources in a catalog the current deployment's

Copy all files from the public sources in a catalog to the current deployment's

dsotirho-ucsc · 2025-03-11T16:38:54Z

scripts/mirror.py

+mirroring bucket. The actual file-copying is not yet implemented, so all this
+currently does is send messages to the indexer app that don't do anything.


Consider adding a FIXME or reference to #6856 ?

dsotirho-ucsc · 2025-03-11T16:44:05Z

scripts/mirror.py

+        sys.exit(1)
+
+
+def main(args):


Should this script be allowed to run if mirroring is not enabled on the deployment?

If mirroring is disabled, the script will fail when it tries to send messages to a nonexistent queue. But adding an additional check will make the cause of the error clearer.

github-actions bot added the orange [process] Done by the Azul team label Feb 12, 2025

nadove-ucsc added the chained [process] PR needs to based of develop before merging label Feb 12, 2025

nadove-ucsc force-pushed the issues/nadove-ucsc/6859-create-mirror-queues-bucket branch 3 times, most recently from ee67822 to 7699551 Compare February 14, 2025 23:40

nadove-ucsc changed the base branch from issues/nadove-ucsc/6859-create-mirror-queues-bucket to issues/nadove-ucsc/6906-chained-prs-fail-immediately-check-branch February 15, 2025 06:23

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch from 55f82f4 to dd75340 Compare February 15, 2025 06:25

nadove-ucsc mentioned this pull request Feb 15, 2025

Fix: check_branch.py fails on chained PRs (#6906) #6908

Merged

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch 3 times, most recently from 420ae76 to d2eb7f9 Compare February 15, 2025 07:52

nadove-ucsc mentioned this pull request Feb 20, 2025

Create mirror queues and bucket (#6859) #6893

Merged

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch from d2eb7f9 to 5e6b8ae Compare February 20, 2025 04:08

nadove-ucsc force-pushed the issues/nadove-ucsc/6906-chained-prs-fail-immediately-check-branch branch from 1d794fa to ca2dc54 Compare February 25, 2025 02:46

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch 2 times, most recently from ab16334 to 0eeacd5 Compare February 25, 2025 02:54

nadove-ucsc force-pushed the issues/nadove-ucsc/6906-chained-prs-fail-immediately-check-branch branch 2 times, most recently from 9ea032f to cfa5d15 Compare February 26, 2025 02:02

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch 2 times, most recently from 4e8adbe to bdb55a7 Compare February 26, 2025 02:35

nadove-ucsc force-pushed the issues/nadove-ucsc/6906-chained-prs-fail-immediately-check-branch branch from cfa5d15 to 2466f83 Compare February 26, 2025 02:51

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch 2 times, most recently from 43b2e85 to 6395266 Compare February 26, 2025 04:47

github-advanced-security bot found potential problems Feb 26, 2025

View reviewed changes

src/azul/azulclient.py Fixed Show fixed Hide fixed

src/azul/azulclient.py Fixed Show fixed Hide fixed

src/azul/indexer/mirror_controller.py Fixed Show fixed Hide fixed

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch 3 times, most recently from 6701814 to b9afae4 Compare February 27, 2025 06:56

hannes-ucsc force-pushed the issues/nadove-ucsc/6906-chained-prs-fail-immediately-check-branch branch from 2466f83 to 2b7087d Compare February 27, 2025 06:56

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch from b9afae4 to 265c12c Compare February 27, 2025 08:42

achave11-ucsc assigned dsotirho-ucsc and unassigned achave11-ucsc Mar 10, 2025

achave11-ucsc requested a review from dsotirho-ucsc March 10, 2025 21:35

dsotirho-ucsc requested changes Mar 11, 2025

View reviewed changes

dsotirho-ucsc removed their assignment Mar 11, 2025

nadove-ucsc added 21 commits March 11, 2025 11:49

Fix line wrapping

4193c9a

Fix quotes

cc80a91

Clean up comment, var name, and return type

021f9be

Eliminate old-fashioned type annotations in AzulClient

3996008

Refactor config.all_queue_names

be329a5

raise BadRequestError on invalid Action

fa9834f

Replace string literals with enum members

d604f8c

Extract superclass from Action enum

46e0075

Cache AzulClient in IndexController

611f108

Consolidate message batch size

69fa85b

Consolidate queue getters

15194fc

Consolidate message creation

3573333

Consolidate message body serialization

41fcabd

Consolidate message enqueueing

fa44fd5

Parameterize wait_to_stabilize with queue names

d9955d8

Make methods public

424a940

Change function to field

2c48d35

Extract superclass from TestIndexerController

f705dcd

Implement mirror_source (#6860)

1a54137

fixup! Implement mirror_source (#6860)

2453b86

Add FIXMEs (#6861, #6862)

60375a3

nadove-ucsc dismissed achave11-ucsc’s stale review via 60375a3 March 12, 2025 00:43

nadove-ucsc force-pushed the issues/nadove-ucsc/6860-implment-mirror-source branch from 3e01b45 to 60375a3 Compare March 12, 2025 00:43

nadove-ucsc requested a review from dsotirho-ucsc March 12, 2025 02:07

nadove-ucsc assigned dsotirho-ucsc Mar 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement mirror_source (#6860) #6905

Implement mirror_source (#6860) #6905

nadove-ucsc commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 15, 2025 •

edited

Loading

dsotirho-ucsc left a comment

dsotirho-ucsc Mar 11, 2025

dsotirho-ucsc Mar 11, 2025

dsotirho-ucsc Mar 11, 2025

nadove-ucsc Mar 12, 2025

		@@ -0,0 +1,61 @@
		"""
		Copy all files from the public sources in a catalog the current deployment's

		mirroring bucket. The actual file-copying is not yet implemented, so all this
		currently does is send messages to the indexer app that don't do anything.

Implement mirror_source (#6860) #6905

Are you sure you want to change the base?

Implement mirror_source (#6860) #6905

Conversation

nadove-ucsc commented Feb 12, 2025 • edited Loading

Checklist

Author

Author (partiality)

Author (chains)

Author (reindex, API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator (before pushing merge the commit)

System administrator

Operator (before pushing merge the commit)

Operator (chain shortening)

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Shorthand for review comments

codecov bot commented Feb 15, 2025 • edited Loading

Codecov Report

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

dsotirho-ucsc Mar 11, 2025

Choose a reason for hiding this comment

dsotirho-ucsc Mar 11, 2025

Choose a reason for hiding this comment

dsotirho-ucsc Mar 11, 2025

Choose a reason for hiding this comment

nadove-ucsc Mar 12, 2025

Choose a reason for hiding this comment

nadove-ucsc commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 15, 2025 •

edited

Loading