-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for MacOS with ARM CPUs (CMake + GitHub Action) #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…for build and test
…onflicting?)" This reverts commit 32bd02a.
So far I got it to compile, so I guess the depencies are fine now. But running the tests raises some HDF5 related errors. I've never worked with HDF5 in C++, so maybe @sanathkeshav could you please have a look at the errors? The tests fail with both
|
cmake/FANSConfig.cmake.in
Outdated
@@ -18,7 +18,6 @@ if (NOT HDF5_C_IS_PARALLEL) | |||
message(FATAL_ERROR "Parallel HDF5 implementation (mpi) required but not found!") | |||
endif() | |||
find_dependency(Eigen3) | |||
find_dependency(OpenMP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems to be unrelated to this pull request. Please revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is part of the remove OpenMP dependency PR. I merged it into this PR to make it work temporarily.
Since we could not come to a consensus on how to proceed with this issue, I would propose to close this PR at this point. |
Fine for me. If you don't need the MacOS support at the moment, I don't think we need to invest more time here. |
The macOS test fails with the errors: /Users/runner/work/FANS/FANS/include/solver.h:364:68: error: use 'template' keyword to treat 'get' as a dependent template name
const std::string &measure = reader.errorParameters["measure"].get<std::string>();
^
template
/Users/runner/work/FANS/FANS/include/solver.h:390:68: error: use 'template' keyword to treat 'get' as a dependent template name
const std::string &error_type = reader.errorParameters["type"].get<std::string>();
^
template which seems to have some solutions, for example as stated in this post. I am no expert in C++ templates, but could this error occur because we now enforce a C++ standard Line 17 in 07ee5d8
I would suggest trying to resolve the errors above, because having a macOS test is nice, and @siggmo already invested effort here, so it would be a pity to waste it now. |
Closes #21
Add support for macOS.
Changes in
CMakeLists.txt
:New GitHub Actions workflow file for building and testing on macOS:
macos-14
GitHub hosted runner (M1 CPU)clang
C++ compiler (CMake default on macOS)