-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add py312 support #1
Conversation
clean up test_import_and_version
clean up test_import_and_version
Drop the `install pre-commit` step here, as it is installed for all linting ci via the tox env deps
Add `pre-commit install` here since it was removed from ci config
…, also bump blocklint version
* `sphinx-autobuild` for live docs updates. * Use Python 3.9 and `sphinx-autobuild` `2024.2.4`
add `python -m` to the Makefile `test` command
drop sphinx-autobuild dep back to allow py3.8 to install
* Store artifacts in docs CI * Force `pytest` import above all else
bump-my-version
remove unneeded upstream git check
- We should create a breaking changes branch to be merged only when we are ready to start the next major version release cycle for all our maintained libraries.
making -> make
newsfragment should not be italics
Upgrade template, add py313 support, replace `bumpversion` with `bump-my-version`
Reviewer's Guide by SourceryThis pull request adds support for Python 3.13, updates dependencies, improves documentation, and refactors code for better type safety and maintainability. It also includes changes to the CI configuration, Makefile, pyproject.toml, README.md, tox.ini, and pre-commit-config.yaml files. Updated class diagram for BaseBlockclassDiagram
class BaseBlock {
+transaction_builder
+__init__(header: BlockHeaderAPI, transactions: Sequence[SignedTransactionAPI], uncles: Sequence[BlockHeaderAPI], withdrawals: Sequence[WithdrawalAPI])
+get_transaction_builder()
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dargon789 - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hardcoded address for BEACON_ROOTS_ADDRESS. (link)
Overall Comments:
- It looks like you've incremented to Python 3.13 in some places but are still using Python 3.12 in others; please ensure consistency.
- The
bump
argument in theMakefile
'srelease
target should be validated before being passed tobumpversion
. - Consider using
taskipy
instead ofmake
for task management.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add py312 support #1
What was wrong?
Related to Issue #
Closes #
How was it fixed?
Todo:
Cute Animal Picture
Summary by Sourcery
Adds support for Python 3.13 to the project, updating the CI configuration, Makefile, pyproject.toml, README, tox.ini, pre-commit-config.yaml, setup.py, and documentation.
Enhancements:
CI:
Tests: