fix: skip Cancel in QueryUnbufferedAsync when reader is drained (#2188)#2207
Open
leno23 wants to merge 1 commit into
Open
fix: skip Cancel in QueryUnbufferedAsync when reader is drained (#2188)#2207leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Npgsql keeps IsClosed false after the result set is fully consumed, which caused an unnecessary cmd.Cancel() on every completed unbuffered query. Only cancel when enumeration did not finish draining the reader. Fixes DapperLib#2188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryUnbufferedAsyncfinished reading all rows and result sets (readerDrained).cmd.Cancel()in thefinallyblock when the reader was not fully drained and is still open.This avoids unnecessary command cancellation on providers such as Npgsql where
DbDataReader.IsClosedremainsfalseafter the result set is fully consumed, which was causing extra connection churn and server-side cancel overhead.Test plan
TestBasicStringUsageUnbufferedAsync/ cancellation tests (CI)QueryUnbufferedAsyncto completion and confirm noCANCELis issued in PostgreSQL logsCI not run locally (no .NET SDK in contributor environment).
Fixes #2188
Made with Cursor