Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the primary key field to source streams #1366

Merged
merged 12 commits into from
Feb 5, 2025
Merged

added the primary key field to source streams #1366

merged 12 commits into from
Feb 5, 2025

Conversation

himanshudube97
Copy link
Contributor

No description provided.

@himanshudube97 himanshudube97 self-assigned this Jan 8, 2025
@himanshudube97 himanshudube97 linked an issue Jan 8, 2025 that may be closed by this pull request
allow users to select primary key while creating/updating the connection #1298
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.03%. Comparing base (f45e310) to head (cc40bb6).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...rc/components/Connections/CreateConnectionForm.tsx 46.15% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   71.13%   71.03%   -0.10%     
==========================================
  Files         102      102              
  Lines        7268     7292      +24     
  Branches     1670     1683      +13     
==========================================
+ Hits         5170     5180      +10     
- Misses       1974     2082     +108     
+ Partials      124       30      -94

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshudube97 himanshudube97 changed the title added the primary key field - without multiselect added the primary key field to source streams Feb 2, 2025
@Ishankoradia Ishankoradia self-requested a review February 5, 2025 11:24
@Ishankoradia Ishankoradia merged commit 916914f into main Feb 5, 2025
3 of 5 checks passed
@Ishankoradia Ishankoradia deleted the 1298-allow-users-to-select-primary-key-while-creatingupdating-the-connection branch February 5, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatchat fatchat fatchat left review comments

@Ishankoradia Ishankoradia Ishankoradia approved these changes

Assignees

@himanshudube97 himanshudube97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow users to select primary key while creating/updating the connection
3 participants
@himanshudube97 @fatchat @Ishankoradia