-
Notifications
You must be signed in to change notification settings - Fork 74
setup connection pooling and singleton classes for warehouse queries #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/dalgo-v2
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
||
| @classmethod | ||
| def get_warehouse_client( | ||
| cls, org_warehouse: OrgWarehouse, connection_tier: str = "medium" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will default to medium. But, what will you pass for v2 in prod? Medium or Large?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ishankoradia - I am good with the changes. However, I am not sure of the user limit we might hit with this - with 5 pool size I believe we should be covered but will be good to test the limits with minimum 30 concurrent users all creating DB connections to see we are fine.
Not for now, but for later do you think a retry logic with backoff is needed here?
|
I dont think we need a retry for now. |
No description provided.