Skip to content

Clean up some OpenGL feature detection cruft #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025

Conversation

slipher
Copy link
Member

@slipher slipher commented Jul 14, 2025

Remove unused extensions, workarounds related to them, and useless log messages.

slipher added 3 commits July 14, 2025 01:56
This was used for the color buffer in a previous iteration of
overbright.
- Use the newer extension list API when OpenGL version >= 3.0,
  rather than when it is >= 3.2.
- Check for context "forward compatibility" when the OpenGL version >=
  3.0, rather than when a core profile is in use.
Almost because until 0.56 it's still there in the glconfig_t IPC struct.

Also nuke accompanying logspam which provides no new information and
falsely suggests that there are discrete "modes" depending on the OpenGL
version number.
@illwieckz
Copy link
Member

  • NUKE RGBA16 format handling: LGTM
  • Enable 2 OpenGL introspections based on version >=3.0 : I have no idea what is “forward compatibility”, but I do know that I never had to care about, so, LGTM I guess.
  • (Almost) NUKE glDriverType_t: Great, I have no idea as well what was an ICD or standalone driver, but reading the comments about 3Dfx I know that's some very obsolete stuff. The only reason I did not pruned that myself before is that I don't use Windows and I had a doubt that there may be still something relevant on Windows, but since you use Windows, you are the one who know it is not relevant. LGTM.

@slipher slipher changed the title Clean up some OpenGL feature detection cruft. Clean up some OpenGL feature detection cruft Jul 16, 2025
@slipher slipher merged commit 3ea7958 into DaemonEngine:master Jul 17, 2025
9 checks passed
@slipher slipher deleted the gl-feature-cruft branch July 17, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants