Only update PushBuffer if any uniform has actually changed #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
force-pushed
the
push-buffer-update
branch
2 times, most recently
from
bec3aa0 to
ad58d5c
Compare
|
Also added a fix for |
VReaperV
force-pushed
the
push-buffer-update
branch
2 times, most recently
from
f67e29b to
e84d583
Compare
|
Changed the initial commit and added a new one, now it mutualises |
VReaperV
force-pushed
the
push-buffer-update
branch
from
80717b6 to
8832f45
Compare
VReaperV
force-pushed
the
push-buffer-update
branch
3 times, most recently
from
fedb60c to
fc2fff3
Compare
VReaperV
force-pushed
the
push-buffer-update
branch
from
fc2fff3 to
bf51f59
Compare
This was referenced Aug 27, 2025
Adds `PushBuffer` class, `pushBuffer` global, and the supporting code for `glconfig2`.
Also adds `GLShader.pushSkip` and `GLShader._pushUniforms`. Add `padding` back to the `GLShader` size calculations in material system.
Will be required for `PushBuffer` to set global uniform values outside of their shaders.
This will set `GLShaderManager.globalUniformBlock` to the struct + defines text, which will be the same for all shaders.
This will be required for `PushBuffer` to correctly sort uniforms. Also updates `GLShader.WriteUniformsToBuffer()` to use `mode` and `filter` arguments to select the correct uniforms.
Post-process shaders to actually add the `globalUniformBlock`, add `SetConstUniforms()` and `SetFrameUniforms()` functions to the core and material system renderers, and add the supporting glsl code.
Also mutualises `uniformFirewall` and `currentValue` and removes a bunch of unneeded code.
VReaperV
force-pushed
the
push-buffer-update
branch
from
bf51f59 to
2b38e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1684
Further improvement for PushBuffer, only update it if it's actually required.