Implement GL timer queries #1239
Conversation
Add GL timers for major parts of the engine (frame, depth pre-pass, opaque, transparent, post-process, cull and depth reduction)
| @@ -313,6 +314,10 @@ namespace Render { | |||
| IPC::Message<IPC::Id<VM::QVM, CG_R_GETSHADERNAMEFROMHANDLE>, int>, | |||
| IPC::Reply<std::string> | |||
| >; | |||
| using GetEngineTimersMsg = IPC::SyncMessage< | |||
| IPC::Message<IPC::Id<VM::QVM, CG_R_GETENGINETIMERS>>, | |||
| IPC::Reply<EngineTimers*> | |||
There was a problem hiding this comment.
Sending a pointer through inter-process communication doesn't make sense.
There was a problem hiding this comment.
Yeah, I think it can just be made shared instead.
| } | ||
|
|
||
| // This will retrieve the time in nanoseconds if this query was issued before, otherwise 0 | ||
| // This will block the CPU until the query becomes available |
There was a problem hiding this comment.
Are there any cases where it can really block? If so I guess we should avoid updating the timers when they are not being used.
There was a problem hiding this comment.
Yea, the plan is to have a cvar to enable/disable timers completely. Hence why the pr is draft, here just so it doesn't get lost.
VReaperV
added
T-Improvement
Somehow I've missed this comment. Cgame is only supposed to receive the data and display it if some cvar is enabled. I'll be redoing a large part of cgame side of this anyway. |
Add GL timers for major parts of the engine (frame, depth pre-pass, opaque, transparent, post-process, cull and depth reduction)