Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flink): #398 fix flinksql built-in function's using #399

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix(flink): #398 fix flinksql built-in function's using #399

merged 2 commits into from
Feb 14, 2025

Conversation

Cythia828
Copy link
Collaborator

  1. -- 将原本的functionName中的保留字函数名拆分成普通保留字函数名（需要带括号加参数进行使用的）、无参数保留字函数名（无需带括号也无需带参数进行使用的）、跟随参数的保留字关键字函数名（不需要带括号，后面直接跟参数进行使用的）
  2. -- 在原本使用functionName的地方替换成 functionNameWithParams(functionParam) ｜ reservedKeywordsNoParamsUsedAsFuncName ｜ functionNameAndParams
  3. -- 在进行实体类型收集时，preferredRules除了原本的functionName规则，还需要新增1中说明的几类，并且将其都识别为FUNCTION 实体类型
  4. -- 为涉及到变化的内置函数名新增测试SQL并保证单测通过

@Cythia828 Cythia828 force-pushed the fix_flink_syntax branch 2 times, most recently from a77b789 to 8dde885 Compare February 14, 2025 06:37
liuxy0551
liuxy0551 reviewed Feb 14, 2025
View reviewed changes
@liuxy0551
Copy link
Collaborator

+1

@mumiao mumiao merged commit f8afbe2 into DTStack:main Feb 14, 2025
6 checks passed
@Cythia828 Cythia828 mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumiao mumiao mumiao approved these changes

@liuxy0551 liuxy0551 liuxy0551 approved these changes

@LuckyFBB LuckyFBB LuckyFBB approved these changes

@JackWang032 JackWang032 JackWang032 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cythia828 @liuxy0551 @mumiao @LuckyFBB @JackWang032