add formValues and formErrors to /current-name #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EDIT: I now realize there are more routes that need the implementation...I wonder what other TS errors are making this a pain.
I think we can all agree TS is a pain sometimes. Originally we had partially agreed to remove the persistent error messages/partial validated default form values on language toggle. Instead of completely removing it, why not instead make it work for
the routethat didn't have this feature? If it's still a flop, let's remove it completely.Types of changes
What types of changes does this PR introduce?
(check all that apply by placing an
x
in the relevant boxes)Checklist
Before submitting this PR, ensure that you have completed the following. You can fill these out now, or after creating the PR.
(check all that apply by placing an
x
in the relevant boxes)Linting and formatting
Unit and e2e tests
npm run test npm run test:e2e
Additional Notes
If this PR introduces significant changes, explain your reasoning and provide any necessary context here. Feel free to include diagrams, screenshots, or alternative approaches you considered.
Screenshots (if applicable)
Provide screenshots or screen-recordings to help reviewers understand the visual impact of your changes, if relevant.