[Port dspace-8_x] Escape html tags in innerHTML #4737 #4882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rough an innerHTML attribute or not to properly escape them
…rt-4737-to-dspace-8_x
alexandrevryghem
added
bug
high priority
component: Item
alexandrevryghem
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
tdonohue
requested changes
Dec 3, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
@bram-maegerman : Thanks also for this backport. Similar to my review on #4881, I believe there's a few minor bugs in this backport. Also there's a change that is unrelated to this PR. See inline below.
Once this is updated, I can retest / rereview.
| for (const inputKey of inputKeys) { | ||
| if (inputKey.includes('*')) { | ||
| const inputKeyRegex = new RegExp('^' + inputKey.replace(/\\/g, '\\\\').replace(/\./g, '\\.').replace(/\*/g, '.*') + '$'); | ||
| const inputKeyRegex = new RegExp('^' + inputKey.replace(/\./g, '\\.').replace(/\*/g, '.*') + '$'); |
Member
There was a problem hiding this comment.
Please remove this change, as this seems to be reverting a different bug fix. In other words this change is not in the original PR you are backporting.
| [innerHTML]="item.firstMetadataValue('dc.publisher') + ', '"></span> | ||
| [innerHTML]="item.firstMetadataValue('dc.publisher', undefined, true) + ', '"></span> | ||
| <span class="item-list-date" | ||
| [innerHTML]="item.firstMetadataValue('dc.date.issued') || ('mydspace.results.no-date' | translate)"></span>) |
Member
Comment on lines
+36
to
37
| <span [ngClass]="{'text-muted': !item.hasMetadata('dc.description.abstract')}" | ||
| [innerHTML]="(item.firstMetadataValue('dc.description.abstract')) || ('mydspace.results.no-abstract' | translate)"></span> |
Member
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👀 Under Review
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #4737 by @bram-maegerman to
dspace-8_x