Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier 0 Changes #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tier 0 Changes #272

wants to merge 1 commit into from

Conversation

sachin-panayil
Copy link
Contributor

module-name: Tier 0 Changes

Problem

Tier 0 should be the baseline level for repositories that don't require any project owner input. Community files such as README should be removed

Solution

Removed the README and CONTRIBUTING and added CODEOWNERS and a supporting repolinter.json. The repolinter.json inherits from Tier 0 and just sets values to off only requiring the baseline stuff

Result

Tier 0 now only has baseline files included in it and a supporting repolinter.json that can be used via repolinter-actions

Some important notes regarding the summary line:

  • This is a first draft and would love some feedback as to how we can make this better!
  • I know there are some docs that explain each tier so we for sure need to update that as well. If someone could point to where this lives, I can do that

Test Plan

Tested locally with repolinter lint .

Signed-off-by: Sachin Panayil <[email protected]>
@@ -1,145 +0,0 @@
# {{ cookiecutter.project_name }}
{{ cookiecutter.project_description }}
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally an advocate for keeping README.md since I think a project description is essential to have in a repository for context. Remy and I were exploring maybe generating a description using code.json. For example:

“REPONAME is a LANGUAGE project by CMS that PURPOSE by TEAM for REASON”

@@ -1,115 +0,0 @@
<!--- # NOTE: Modify sections marked with `TODO` -->

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good to remove!

Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving as of now because I have to catch you up on all the changes we made to the maturity model framework. We'll discuss in our meeting soon.

Afterwards, could you handle making some README docs updates to the tier directories?
https://github.com/DSACMS/repo-scaffolder/blob/main/tier1/README.md

@@ -0,0 +1,177 @@
{
"extends": "https://raw.githubusercontent.com/DSACMS/repo-scaffolder/main/tier1/%7B%7Bcookiecutter.project_slug%7D%7D/repolinter.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tier 0 is now considered the tier with our baseline repository requirements, I think it may be worth refactoring our repolinter.json files such that Tier 0 is the parent and Tier 1-4 extends from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants