Allow skipping smoke tests

[rjarry]

Allow skipping individual tests with:

./smoke/run.sh -s bgp6_srv6_frr_test.sh build/

Or test patterns with:

./smoke/run.sh -s '*srv6*' -s '*bgp*' build/

[coderabbitai]

📝 Walkthrough

Walkthrough

The shell script now runs with strict mode (set -eu), replaces the old single-argument run() wrapper with a positional-argument parser that accepts -s/--skip to collect skip patterns, and treats unknown options as errors. A skip_test() helper checks patterns; the main test loop uses it to label and avoid running skipped tests. Legacy coredump/sysctl/ulimit setup was removed. Non-option arguments are used to determine the build directory.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5a1d95 and 6a9a311.

📒 Files selected for processing (1)

• smoke/run.sh (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.sh

⚙️ CodeRabbit configuration file

**/*.sh: - Don't bother about unquoted shell variables.

Files:

• smoke/run.sh

🪛 Shellcheck (0.11.0)

smoke/run.sh

[warning] 32-32: Quote expansions in case patterns to match literally rather than as a glob.

(SC2254)

🔇 Additional comments (1)

smoke/run.sh (1)

14-17: ✅ Skip pattern functionality properly implemented.

The array append fix on line 16 (skip_patterns+=("$1")) is correctly applied and enables multiple -s flags to accumulate patterns as separate array elements. The skip_test() function properly iterates through patterns using glob matching (unquoted $pattern is intentional), and the test loop integration correctly skips matching tests. The argument parser correctly shifts through both flags and values.

Also applies to: 28-38, 57-60

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63a92aa and a0facc2.

📒 Files selected for processing (1)

• smoke/run.sh (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.sh

⚙️ CodeRabbit configuration file

**/*.sh: - Don't bother about unquoted shell variables.

Files:

• smoke/run.sh

🪛 Shellcheck (0.11.0)

smoke/run.sh

[warning] 16-16: Use array+=("item") to append items to an array.

(SC2179)

---

[warning] 32-32: Quote expansions in case patterns to match literally rather than as a glob.

(SC2254)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: rpm
• GitHub Check: deb
• GitHub Check: build-and-tests (gcc-14, address, debug, ubuntu-24.04, -Dfrr=enabled, true)
• GitHub Check: build-and-tests (gcc-13, none, debugoptimized, ubuntu-24.04, -Dfrr=enabled, false)
• GitHub Check: build-and-tests (clang-16, none, debugoptimized, ubuntu-24.04, false)
• GitHub Check: build-and-tests (clang-15, none, debugoptimized, ubuntu-22.04, false)
• GitHub Check: build-and-tests (clang-18, none, debugoptimized, ubuntu-24.04, false)
• GitHub Check: build-cross-aarch64

[christophefontaine]

@rsafrono does it work for you ? If yes, can you approve the changes or add a tested by tag ?
Thank you !

[rsafrono]

Tested-by: Roman Safronov [email protected]