DNS object, parsing, respdiff #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `core.object.dns`: - Issue DNS-OARC#39: Remove private struct and pull in `omg-dns` code - Issue DNS-OARC#39: Add constants and strings for class, type, opcode, rcode etc - Add new objects `core.object.dns.label`, `core.object.dns.q` and `core.object.dns.rr` - Make it possible to reuse a `core.object.dns` for parsing another payload - Rework the way parsing more then just the header is done: - Remove functions `rr_reset()`, `rr_ok()`, `rr_label()`, `rr_type()`, `rr_class()` and `rr_ttl()` - Remove attributes `questions`, `answers`, `authorities` and `additionals` - Add function `parse_q()` and `parse_rr()` - Payload object is now optional for `new()` - Change `parse()`, see documentation - Remove old (non-working) functions `src()` and `dst()` - Remove old (unused) attributes `src_id`, `qr_id`, `dst_id`, `sport` and `dport` - `print()` now displays textual representation of types and codes - `core.object`: Remove prefix for constants - `examples/*`: - Add `respdiff.lua`, based on `playqr.lua` but only uses `output.respdiff` - Remove `playqr.lua` - Update all examples with changes made to `core.object` and `core.object.dns` - `README.md`/Makefiles: Remove `omg-dns` dependency - `filter.layer`: Update parsing to use `memcpy()` and `bswap_nn()` for possible assembler optimization - `input.fpcap`: Update parsing to use `bswap_nn()` for possible assembler optimization - `input.mmpcap`: Update parsing to use `bswap_nn()` for possible assembler optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.object.dns:omg-dnscodecore.object.dns.label,core.object.dns.qandcore.object.dns.rrcore.object.dnsfor parsing another payloadrr_reset(),rr_ok(),rr_label(),rr_type(),rr_class()andrr_ttl()questions,answers,authoritiesandadditionalsparse_q()andparse_rr()new()parse(), see documentationsrc()anddst()src_id,qr_id,dst_id,sportanddportprint()now displays textual representation of types and codescore.object: Remove prefix for constantsexamples/*:respdiff.lua, based onplayqr.luabut only usesoutput.respdiffplayqr.luacore.objectandcore.object.dnsREADME.md/Makefiles: Removeomg-dnsdependencyfilter.layer: Update parsing to usememcpy()andbswap_nn()for possible assembler optimizationinput.fpcap: Update parsing to usebswap_nn()for possible assembler optimizationinput.mmpcap: Update parsing to usebswap_nn()for possible assembler optimization