Skip to content

feat(compliance): review refinements and KYC step overview cleanup (DEV-4574)#1105

Merged
bernd2022 merged 2 commits into
developfrom
feature/DEV-4574-compliance-review-refinements
May 19, 2026
Merged

feat(compliance): review refinements and KYC step overview cleanup (DEV-4574)#1105
bernd2022 merged 2 commits into
developfrom
feature/DEV-4574-compliance-review-refinements

Conversation

@bernd2022
Copy link
Copy Markdown
Collaborator

Summary

  • Only steps with status ManualReview are actionable for compliance (review, ident, stammdaten, bankdata panels) — Completed/Failed/InternalReview show an informational message
  • BankData Review tab badge + color counts only ManualReview entries; multiple ManualReview entries are listed
  • Ident panel: birthday now read from step result (parsed.birthday or data.info.dob), no fallback to userData.birthday; display includes age via new shared formatBirthday helper
  • Transaction detail rows show compliance-internal terms: AmlCheck, AmlReason, Comment (instead of customer-facing State / Failure Reason)
  • Pending Onboardings section removed (covered by Pending Reviews)
  • Pending Reviews overview: stable canonical order derived from reviewTabs, always shows all rows (zero counts included), badge total counts only ManualReview
  • Review tabs reordered (Ident moved before LegalEntity) — single source of truth for KYC step order
  • Nationality / Aufenthaltsbewilligung info items now render label-left / value-right (matches other tabs)
  • Tailwind: added dfxYellow palette; replaced standard Tailwind colors that were rendering invisible (custom theme had stripped defaults)
  • calculateAge consolidated into formatBirthday (5 callsites unified to one format)

Test plan

  • Compliance review screen: open user in ManualReview step → decision fields editable; open Completed/Failed/InternalReview step → message shown, no decision UI
  • BankData Review tab: badge matches count of ManualReview bankDatas only; bankData name mismatch highlighted in red; alternative bankData section shows when an approved bankData with same IBAN exists
  • Ident review: birthday shows as dd.mm.yyyy (X Jahre) when result contains data; falls back to - when result is empty
  • Transaction detail expansion: rows show AmlCheck, AmlReason, Comment
  • Compliance dashboard: Pending Onboardings section gone; Pending Reviews shows all rows (incl. zero counts) in correct order; total count = ManualReview only
  • Review tab order: Ident appears before LegalEntity
  • Nationality + Aufenthaltsbewilligung tabs: label/value cleanly aligned left/right
  • Visual: yellow/red/green status dots and warning texts are visible (not white-on-white)

@bernd2022 bernd2022 marked this pull request as ready for review May 19, 2026 13:32
@bernd2022 bernd2022 requested a review from TaprootFreak as a code owner May 19, 2026 13:32
@bernd2022 bernd2022 merged commit c028a7d into develop May 19, 2026
6 checks passed
@bernd2022 bernd2022 deleted the feature/DEV-4574-compliance-review-refinements branch May 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants