Release: develop -> main#3676
Merged
TaprootFreak merged 6 commits intomainfrom May 7, 2026
Merged
Conversation
* feat(payment-link): add urble wallet app (BTC/Cardano) * feat(payment-link): restrict urble assets to BTC, ADA, dEURO, USDT, USDC
A single failing token (e.g. broken decimals() call) in getTokenBalances could abort the entire loop, preventing balance updates for all tokens on that chain. Wrap each token iteration in try/catch so other tokens continue processing when one fails.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
* fix: treat Scrypt WS Connection closed as transient
The Scrypt WebSocket adapter rejects all pending requests with
'Connection closed' when the WS disconnects. Previously this surfaced as
a permanent OrderFailedException in the liquidity management pipeline,
causing the rule to be paused even though the underlying order on Scrypt
was still alive (no fill, no money moved).
Two changes:
- ScryptWebSocketConnection: extend the 'fetchAll' retry pattern to also
cover 'fetch'. Refactor the retry logic into a shared helper so any
future fetch-style call gets the same treatment.
- ScryptAdapter.checkTradeCompletion: when the underlying error is a
transient WS error (Connection closed / unknown reqid), return false
instead of throwing OrderFailedException, so the order stays
IN_PROGRESS and is retried on the next cron tick.
Reproduced via pipeline 60738 (rule 313, Scrypt/EUR redundancy): order
122805 went through 5 ClOrdIds in 3 minutes before WS dropped during a
check, was wrongly marked Failed; balance audit confirmed the EUR were
never spent.
* refactor: share transient-ws-error detection between WS layer and adapter
Centralize the transient WS error markers ('Connection closed' /
'unknown reqid') and a shared isTransientWsError helper in
scrypt-websocket-connection. Both retryOnTransientWsError and the
ScryptAdapter check now use the same function, eliminating the
duplicated string list and aligning the case-insensitive matching with
isBalanceTooLowError elsewhere in the adapter.
* feat: improved mail branding * feat: simplified wallet lookup * fix: after merge cleanup
Member
|
Fixes #3595 |
TaprootFreak
approved these changes
May 6, 2026
davidleomay
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist