make deathcause an api for getting the cause of death
#1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it more api-like
Remove the console formatting Signed-off-by: Squid Coder <[email protected]>
Format to keep old usage working Signed-off-by: Squid Coder <[email protected]>
myk002
reviewed
Apr 12, 2025
There was a problem hiding this comment.
could you remove the leftover parens from the return statements?
Also, needs a module declaration and standard side effects guard. See: https://docs.dfhack.org/en/latest/docs/dev/Lua%20API.html#importing-scripts
final fixes
myk002
reviewed
Apr 13, 2025
myk002
reviewed
Apr 14, 2025
localize some more functions and then rename the APIs and add comments
|
needs a changelog and documentation |
Bumber64
reviewed
Jun 27, 2025
|
|
||
| local DEATH_TYPES = reqscript('gui/unit-info-viewer').DEATH_TYPES | ||
|
|
||
| -- Gets the first corpse item at the given location | ||
| function getItemAtPosition(pos) | ||
| local function getItemAtPosition(pos) | ||
| for _, item in ipairs(df.global.world.items.other.ANY_CORPSE) do | ||
| if item.pos.x == pos.x and item.pos.y == pos.y and item.pos.z == pos.z then |
There was a problem hiding this comment.
Not important, but this check can be if same_xyz(pos, item.pos) then.
|
i have tested this PR locally and it doesn't cause any malfunction. i haven't confirmed that the added functionality works as expected, but at least it shouldn't introduce a regression. CI testing isn't working correctly for some reason i can't explain i will approve this once the API it introduces is documented |
ab9rf
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made this on my phone, might have errors so please dbl check