Skip to content

Conversation

@TymurGubayev
Copy link
Contributor

No description provided.

@TymurGubayev
Copy link
Contributor Author

btw, this is why I originally used the create_row({t=t},...); t=t+1 approach: currently to move the bottom 4 widgets down, I had to modify 4 additional lines.

@myk002 myk002 added this to 51.06-r2 Mar 2, 2025
@github-project-automation github-project-automation bot moved this to Todo in 51.06-r2 Mar 2, 2025
@github-project-automation github-project-automation bot moved this from Todo to Review In Progress in 51.06-r2 Mar 2, 2025
@myk002
Copy link
Member

myk002 commented Mar 2, 2025

btw, this is why I originally used the create_row({t=t},...); t=t+1 approach: currently to move the bottom 4 widgets down, I had to modify 4 additional lines.

In the past, I've tried to find a balance here. I felt that t=t+1 made the code too messy and prevented the usual idiom of adding the widgets in a single call to self:addviews{}. setting autoarrange_subviews=true might be an option. A compromise that I've found works well is to group widgets into Panels, so only the Panel frame changes when things get rearranged, and the only inner widget frames that need to be modified are the ones in the modified Panel.

@myk002 myk002 merged commit eb4ea81 into DFHack:master Mar 2, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in 51.06-r2 Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants