Feat/adventurer journal #1409
Merged
Feat/adventurer journal #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
approved these changes
Mar 7, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
Looks great! I suspect players will want the ability to pull up journals of non-current adventurers, but we need to provide a Lua API for pulling data by key pattern like we have for C++ to support that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add adventure mode support for
gui/journal.The journal is stored per ID for the character the player created on the save.
It's not support
bodyswapand other tools - using them u changing ur character, and new one will have new journal!Also, add dedicated intro text for journal on adventure mode.
I do not see a way to test journal on CI in adventure mode right now.