Skip to content

Fix df.talk_choice_type def not being up to date for internal/convo.lua #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myk002 merged 2 commits into from
Jan 27, 2025
Merged

Fix df.talk_choice_type def not being up to date for internal/convo.lua #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1757cf4
Fix advtools convo using the wrong talk_choice_type for creating new …
Crystalwarrior Jan 26, 2025
791096c
Update changelog
myk002 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ Template for new versions:
# Future

## New Tools

- `autocheese`: automatically make cheese using barrels that have accumulated sufficient milk

## New Features

## Fixes
- `advtools`: fix dfhack-added conversation options not appearing in the ask whereabouts conversation tree

## Misc Improvements
- `assign-preferences`: new ``--show`` option to display the preferences of the selected unit
Expand Down
2 changes: 1 addition & 1 deletion internal/advtools/convo.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ local function addWhereaboutsChoice(race, name, target_id, heard_of)
if heard_of then
title = title .. " (Heard of)"
end
local choice = new_choice(df.talk_choice_type.AskWhereabouts, title, dfhack.translation.translateName(name):split())
local choice = new_choice(df.talk_choice_type.AskForDirectionsToHF, title, dfhack.translation.translateName(name):split())
-- insert before the last choice, which is usually "back"
adventure.conversation.conv_choice_info:insert(#adventure.conversation.conv_choice_info-1, choice)
choice.choice.invocation_target_hfid = target_id
Expand Down
Loading