Feat: Add "show" to pref-adjust #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature returns the list of Likes for a selected dwarf. This script may be useful if: * a user wants to view a quick list of likes for a dwarf * a user wants to view the list of likes after updating a dwarfs likes * Other scripts may find this helpful, as this functionality is not otherwise exposed via dfhack
myk002
reviewed
Jan 18, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
please also add a line to the Misc Improvements section of the "Future" version in changelog.txt
Thanks!
otherwise you'll get an extra error printed to the console when no unit is selected Co-authored-by: Myk <[email protected]>
Functional update: updated script to use call to `dfhack.script_help` function
Added notes to future>misc as requested in PR
Feedback on this is that if a unit is not selected, and this function is called, you will get two errors printed instead of the expected one.
Contributor
Author
|
pre-commit.ci autofix |
myk002
reviewed
Jan 19, 2025
Co-authored-by: Myk <[email protected]>
Co-authored-by: Myk <[email protected]>
Co-authored-by: Myk <[email protected]>
Co-authored-by: Myk <[email protected]>
Co-authored-by: Myk <[email protected]>
myk002
approved these changes
Jan 23, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
looks good! we're in code freeze for the release tomorrow, but I'll merge it soon after we tag
myk002
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature returns the list of Likes for a selected dwarf.
This script may be useful if: