global necronomicon functionality #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Nov 12, 2024
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
could you add a line to https://github.com/DFHack/scripts/blob/master/changelog.txt#L42 under Misc Improvements for this change?
docs/necronomicon.rst
Outdated
| Also list slabs that contain the secrets of life and death. Note that | ||
| dwarves cannot read the secrets from a slab in fort mode. | ||
|
|
||
| ``-w``, ``-world`` |
Member
There was a problem hiding this comment.
Suggested change
| ``-w``, ``-world`` | |
| ``-w``, ``--world`` |
necronomicon.lua
Outdated
| print() | ||
| for _,rec in ipairs(df.global.world.artifacts.all) do | ||
| if df.item_slabst:is_instance(rec.item) and check_slab_secrets(rec.item) then | ||
| print(dfhack.TranslateName(rec.name)) |
Member
There was a problem hiding this comment.
Suggested change
| print(dfhack.TranslateName(rec.name)) | |
| print(dfhack.df2console(dfhack.TranslateName(rec.name))) |
| end | ||
| end | ||
|
|
||
| function necronomicon_world(include_slabs) |
Member
There was a problem hiding this comment.
could you fix the indentation of this function? it should be four spaces per indent, no tabs. The pre-commit.ci autofix might be able to do it for you. (see https://results.pre-commit.ci/run/github/54066125/1728398159.cyDmLoGvQYO2Zc9I5N4ilg )
myk002
approved these changes
Nov 28, 2024
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edits to necronomicon.lua to add a worldwide search function