Bodyswap Improvements and Additions #1164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Crystalwarrior
commented
Jun 9, 2024
Crystalwarrior
commented
- If bodyswap is ran with no arguments, bring up a list of units on the map to bodyswap to
- Bodyswapping adjusts the extra members list, not core party - consistent with vanilla behavior for retiring/unretiring with core party.
- Reveal tiles near the bodyswapped unit
- When bodyswapping to someone with no name, forcibly give them a name
… map to bodyswap to Bodyswapping adjusts the extra members list, not core party - consistent with vanilla behavior for retiring/unretiring with core party. Reveal tiles near the bodyswapped unit
myk002
reviewed
Jun 9, 2024
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
myk002
reviewed
Jun 14, 2024
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
remember to update the bodyswap.rst docs with the new behavior
myk002
reviewed
Jun 22, 2024
Co-authored-by: Myk <[email protected]>
Merge linger into bodyswap
Member
|
I agree with subsuming |
myk002
reviewed
Jul 2, 2024
myk002
reviewed
Jul 2, 2024
Co-authored-by: Myk <[email protected]>
myk002
reviewed
Jul 2, 2024
myk002
reviewed
Jul 3, 2024
myk002
reviewed
Jul 4, 2024
myk002
reviewed
Jul 19, 2024
Contributor
Author
|
@myk002 can this be reviewed? |
Member
myk is on hiatus now, and I'm not going to review a PR that is failing CI or has unresolved merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.