isDanger(): don't mark visitors hostile #5076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Dec 4, 2024
myk002
reviewed
Dec 7, 2024
Member
|
Note to self: when we merge this, revert DFHack/scripts#1343 (and write a more general changelog message about hostile classification. it affects several tools) |
myk002
approved these changes
Dec 7, 2024
myk002
reviewed
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only handles night creatures (the hostile one in the save this patch fixes) and opposed to lifers (necromancers? I don't recall.)
May want this to apply to them all. It is possible for a demon to visit as a merchant.
I don't see anything obvious where this change will cause unwanted side effects in any of the callers of this function.