The function DFHack::Job::removeJob is currently calling the job_handler::cancel_job vmethod with some special hacks to work around GCC being too "clever".
The globals table has been providing us with a function named job_handlerst_remove_job for the past several years, so we should start using it.
We should also notify Toady that he can make that function non-virtual (and also the same for a bunch of other functions he made virtual for "modding hook" use, since those other ones are equally broken).
The function
DFHack::Job::removeJobis currently calling thejob_handler::cancel_jobvmethod with some special hacks to work around GCC being too "clever".The globals table has been providing us with a function named
job_handlerst_remove_jobfor the past several years, so we should start using it.We should also notify Toady that he can make that function non-virtual (and also the same for a bunch of other functions he made virtual for "modding hook" use, since those other ones are equally broken).